Extract Mixin for Ilios Overview#9212
Merged
dartajax merged 3 commits intoilios:masterfrom Mar 10, 2026
Merged
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
force-pushed
the
i6937-ilios-overview
branch
from
a073a6d to
720fc01
Compare
Contributor
✅ Visual Diff Approved❌ Visual Diff Report — FAILED768 images compared: 383 different · 385 identical DetailsDifferences (383)
Download the results. |
jrjohnson
force-pushed
the
i6937-ilios-overview
branch
from
720fc01 to
8f921ff
Compare
Member
Author
|
@dartajax this will need style review of the top of the Program, Program Year, Course, Session, and Learner Group pages as the all have small, but as you can see from the diff, pretty significant space saving differences. |
Member
|
how it was (or is) before this PR ... 
now we have brought up the spacing a little but placed a full strength Ilios-colored standard line - in the context, I think the old faint one might look better ... from the PR ... 
|
Member
|
My comment was about Program Year - Course with details not displayed looks sweet. With details displayed, maybe the same comment I made about Program Year could apply - faint line there instead. |
Member
|
Session - looks great. Learner Groups ... 
Consider re-introducing the padding before the line - and yes adding space to the screen - it'll flow better though. |
Making this a share style instead of a mixin, and removed the course-overview mixin at the same time as it depended on overview. I didn't update the curriculum inventory as that is slated for deprecation.
jrjohnson
force-pushed
the
i6937-ilios-overview
branch
from
8f921ff to
887d6dd
Compare
Member
Author
|
Thanks @dartajax, fixed and pushed. Give everything another look please! |
dartajax
added
the
approve visual diff
packages/frontend/app/styles/components/learner-group/root.scss
Outdated
Show resolved
Hide resolved
Instead of trying to fit this into the ilios-overview styles we can just treat it as it's own unique thing. Which it is.
jrjohnson
force-pushed
the
i6937-ilios-overview
branch
from
887d6dd to
10912a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making this a share style instead of a mixin, and removed the course-overview mixin at the same time as it depended on overview. I didn't update the curriculum inventory as that is slated for deprecation.
Refs ilios/ilios#6937
Fixes ilios/ilios#6963